Skip to content

fix(datatool) hardened derivation paths #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(datatool) hardened derivation paths #808

wants to merge 3 commits into from

Conversation

Zk2u
Copy link
Contributor

@Zk2u Zk2u commented May 16, 2025

Description

This PR updates the derivation of keys for the operator to match that of the secret service. We are using hardened keys so converting a base xpub to a child P2P/wallet xpub is no longer possible.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@Zk2u Zk2u self-assigned this May 16, 2025
@Zk2u Zk2u requested review from a team as code owners May 16, 2025 14:46
@Zk2u Zk2u added the bridge Relates to the core bridge machinery label May 16, 2025
@codecov Codecov
Copy link

codecov bot commented May 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 5.88235% with 64 lines in your changes missing coverage. Please review.

Project coverage is 52.54%. Comparing base (34479ee) to head (2d7cf36).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
bin/datatool/src/util.rs 0.00% 41 Missing ⚠️
bin/datatool/src/main.rs 0.00% 12 Missing ⚠️
crates/primitives/src/crypto.rs 0.00% 11 Missing ⚠️ 
@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
+ Coverage   52.23%   52.54%   +0.31%     
==========================================
  Files         298      307       +9     
  Lines       32747    33433     +686     
==========================================
+ Hits        17106    17569     +463     
- Misses      15641    15864     +223
Files with missing lines Coverage Δ
bin/datatool/src/args.rs 0.00% <ø> (ø)
crates/key-derivation/src/operator.rs 93.77% <100.00%> (+4.57%) ⬆️
crates/key-derivation/src/sequencer.rs 93.85% <100.00%> (ø)
crates/primitives/src/constants.rs 100.00% <ø> (ø)
crates/primitives/src/crypto.rs 72.54% <0.00%> (-19.96%) ⬇️
bin/datatool/src/main.rs 0.00% <0.00%> (ø)
bin/datatool/src/util.rs 0.00% <0.00%> (ø)

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2025 •
edited
Loading

Commit: 08d08b8

SP1 Execution Results

program cycles success
Bitcoin Blockspace 71,672 ✅
EVM EE STF 277,604 ✅
CL STF 167,016 ✅
Checkpoint 4,252 ✅

storopoli
storopoli requested changes May 16, 2025
View reviewed changes
Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some very trivial docs and clippy errors in CI.

But mostly important func-tests are blowing up. I don't see right away from the code changes what this might be but this is where things would blow up if the datatool is not properly functioning...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@storopoli storopoli storopoli requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Zk2u Zk2u

Labels
bridge Relates to the core bridge machinery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zk2u @storopoli